Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the label position: relative #134

Open
KeithHenry opened this issue Jan 29, 2020 · 0 comments
Open

Why is the label position: relative #134

KeithHenry opened this issue Jan 29, 2020 · 0 comments

Comments

@KeithHenry
Copy link

Why is the label that wraps the <slot> set to position: relative;?

#radioLabel {
line-height: normal;
position: relative;
display: inline-block;
vertical-align: middle;
margin-left: var(--paper-radio-button-label-spacing, 10px);
white-space: normal;
color: var(--paper-radio-button-label-color, var(--primary-text-color));
@apply --paper-radio-button-label;
}

If I want the label's contents to use relative positioning I can set that myself, but combined with display: inline-block; that really limits what styling can be done inside the label.

Combined with the fact that <paper-radio-button> only works as a direct child of <paper-radio-group> you have really limited options - any kind of grid is impossible without overriding the flakey --paper-radio-button-label mixin (we're using constructable stylesheets so need a specific hack).

Could we change it to not have any explicit positioning?

KeithHenry added a commit to KeithHenry/paper-radio-button that referenced this issue Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant