You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
test-helpers.js and other files use a complicated pass-global-and-scope-object-to-an-iife method of defining things in an effort to support both some complex loading situations and closure-compiler compilation.
An explanation and understandable emotional reaction may be found here. #69
As a member of the closure-compiler team, I'd like to suggest that you just use window.foo = ... to define your globals. My rationale is this:
You are polymer. You must be running in a browser environment, so you know window is always available.
You're already using window in lots of the implementations anyway.
We're moving rapidly toward a strict-mode-only world. In strict mode this isn't even defined in global scope.
The text was updated successfully, but these errors were encountered:
This is an offshoot of #85
test-helpers.js and other files use a complicated pass-global-and-scope-object-to-an-iife method of defining things in an effort to support both some complex loading situations and closure-compiler compilation.
An explanation and understandable emotional reaction may be found here.
#69
As a member of the closure-compiler team, I'd like to suggest that you just use
window.foo = ...
to define your globals. My rationale is this:window
is always available.window
in lots of the implementations anyway.this
isn't even defined in global scope.The text was updated successfully, but these errors were encountered: