Fix resetting of paper-input and paper-textarea #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notwaldorf
force-pushed
the
fix-reset
branch
from
b255730
to
761d62a
Compare
notwaldorf
changed the title
| @@ -16,6 +16,8 @@ | |||
| <script src="../../web-component-tester/browser.js"></script> | |||
|
|
|||
| <link rel="import" href="../../polymer/polymer.html"> | |||
| <link rel="import" href="../../paper-input/paper-input.html"> | |||
| <link rel="import" href="../../paper-input/paper-textarea.html"> | |||
There was a problem hiding this comment.
You should import paper-textarea in the bower's devDependencies
There was a problem hiding this comment.
It's in the same package (paper-input), which is already a dependency
|
LGTM! |
notwaldorf
added a commit
that referenced
this pull request
Mar 8, 2016
Fix resetting of paper-input and paper-textarea
|
I am not sure if it is this PR, but there is breakage where form reset causes breakage in paper-radio buttons and paper-dropdown-menu. After a reset, the default selections will no longer show as they did when a form first loads. Please see #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.