New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Améliorer le nom des exports PDF #443

Open

camillemonchicourt opened this issue Apr 6, 2023 · 1 comment

Labels

Member

camillemonchicourt commented Apr 6, 2023

Actuellement, quand on export le PDF d'un rapport d'import, celui-ci est nommé export.pdf.

Il serait plus intéressant de le nommer import-report-ID.pdf (en remplaçant l'ID par celui de l'import concerné).

Éventuellement préfixer le fichier par la date d'export du PDF 2023-04-06-import-report-16.pdf

The text was updated successfully, but these errors were encountered:

camillemonchicourt added the enhancement label

Contributor

bouttier commented Apr 11, 2023

Le nom donné par le backend est nul : https://github.com/PnX-SI/gn_module_import/blob/master/backend/gn_module_import/routes/imports.py#L642

Mais l’améliorer ne sera pas suffisant, car le frontend l’ignore pour mettre son propre nom (nul aussi) : https://github.com/PnX-SI/gn_module_import/blob/master/frontend/app/services/csv-export.service.ts#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment