Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient doesn't support h2 #620

Open
geNAZt opened this issue Aug 19, 2023 · 1 comment
Open

WebClient doesn't support h2 #620

geNAZt opened this issue Aug 19, 2023 · 1 comment

Comments

@geNAZt
Copy link

geNAZt commented Aug 19, 2023

When using WebClient (which is default for spring) the clientConnector built doesn't allow you to set the protocol. Therefore it only supports http/1.1.

Since other clients support http2:

java11: https://github.com/PlaytikaOSS/feign-reactive/blob/develop/feign-reactor-java11/src/main/java/reactivefeign/java11/Java11ReactiveFeign.java#L104
jetty:

I would love to see that the netty connection builder takes the useHttp2 flag into account:
https://github.com/PlaytikaOSS/feign-reactive/blob/develop/feign-reactor-webclient/src/main/java/reactivefeign/webclient/NettyClientHttpConnectorBuilder.java#L73

If wanted i would love to PR this change

Thanks

@kptfh
Copy link
Collaborator

kptfh commented Sep 4, 2024

please make PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants