Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic logging #22

Open
SergioLuis opened this issue Dec 20, 2019 · 1 comment
Open

Add basic logging #22

SergioLuis opened this issue Dec 20, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@SergioLuis
Copy link
Contributor

SergioLuis commented Dec 20, 2019

It would be nice to have logging - even some basic one.
I have not looked thoroughly into this, so I can't apport much more. Investigate if we can use Visual Studio Code logging infrastructure, and create -if needed- a wrapper static class to use it with ease.

@SergioLuis SergioLuis added the good first issue Good for newcomers label Dec 20, 2019
@mig42
Copy link
Contributor

mig42 commented May 12, 2022

Probably the best option for this is to use the OutputChannel and write there all information we need. That's what other extensions seem to do.

For regular commands (update, checkin, etc.) we're not printing neither the cm path nor the command output.

For info commands (the two cm version and cm location that run when starting a shell) we're not printing neither the current directory, nor the cm path, nor the actual command and arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants