Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Movie #607

Open
sbarber2 opened this issue Oct 19, 2024 · 3 comments
Open

Download Movie #607

sbarber2 opened this issue Oct 19, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sbarber2
Copy link
Contributor

It would be nice if users could download movies.

How many times have I wanted to download a movie in the dev.planttracer.com instance so I could use it in my local instance? Many.

It's probably a use case that users in a course will want to share movies in the sense that they may want to do different tracking runs with different marker positions.

I strongly suspect this feature will want access control.

Quick take on what those access rules might be:

  • A user may download any movie they have uploaded
  • A user may download all published movies in courses in which they are registered
  • A course admin may download any movie in that course
  • A super admin may download any movie in the entire database

Yes, of course, users could manage their own movies files elsewhere and share them that way, but being able to download movies from the app is just going to be handy.

@sbarber2 sbarber2 added the enhancement New feature or request label Oct 19, 2024
@simsong
Copy link
Member

simsong commented Oct 19, 2024

You can. Click 'play' and then right-click:
image

@sbarber2
Copy link
Contributor Author

sbarber2 commented Oct 19, 2024

A fair point. So much for access control (if that was ever desired).

OK, that works, more or less.

I tried this in Chrome against dev.planttracer.com on the movie with id 5724. It downloaded the movie to a file named 5724-243a.mov

In MacOS Safari, the file is named get-movie-data with no extension.

In MacOS Firefox (131.0.3), pressing Play on the Movies page for this movie doesn't work, so that'll be a new Issue. (#608)

We can document this for users, as they won't all think of it on their own.

But I'd say given these results, if Download Movie is to be a positive feature of the webapp (rather than an artifact of the browser environment as it is now), then we have some work to do in order to make it both nice and friendly and a bit more user-proof.

@simsong
Copy link
Member

simsong commented Oct 19, 2024

We could certainly create a download link that just downloads the movie if you want that. It's about 5 min to change, just some HTML and JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants