Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] #88

Open
sundaqiang opened this issue Oct 17, 2021 · 8 comments
Open

[Feature Request] #88

sundaqiang opened this issue Oct 17, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@sundaqiang
Copy link

PBRP has the ability to modify codename, can you add a tool to modify more read-only attributes?
Many official upgrade packages now recognize more than Just Codename.
This feature can be adapted to more similar models using a PBRP image.

@sundaqiang sundaqiang added the enhancement New feature or request label Oct 17, 2021
@AndroiableDroid
Copy link
Member

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

@hraj9258
Copy link
Member

@AndroiableDroid Like build fingerprint and few other device specific props

@sundaqiang
Copy link
Author

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft
ro.product.device
ro.product.system.model

There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute.

Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

@AndroiableDroid
Copy link
Member

AndroiableDroid commented Oct 17, 2021

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft ro.product.device ro.product.system.model

There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute.

Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

Does resetprop not work like that?

@sundaqiang
Copy link
Author

Hmmm, sounds good that can be implemented. Can you plz elaborate about the variables which needed more.

ro.separate.soft ro.product.device ro.product.system.model
There will be a lot, I think we can do something like Mprop(https://github.com/jedy/mprop, you can use this tool in the normal system, but can't use in PBRP) such a command-line tool, so that we can in the rc file to perform a custom sh, get the original system and write PBRP attribute.
Many models of the same CPU and the same manufacturer can use the same PBRP image.If you can write the properties of the original system to PBRP after startup, you can save a lot of work.Of course, attributes can vary from vendor to vendor, so a command-line tool that lets developers read and write attributes is most appropriate.

Does resetprop not work like that?

Thank you very much, I found this tool, but for example, after I modify this property (resetProp ro.product.device XXX), the about page of PBRP will not be updated, how should I deal with this?

@AndroiableDroid
Copy link
Member

Ya that could be figure out. Resetprop working fone for you?

@sundaqiang
Copy link
Author

Useful, but does not update information about the page in real time

@sundaqiang
Copy link
Author

Ya that could be figure out. Resetprop working fone for you?

Thanks, I've taken care of my thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants