Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages without meta block are rendered empty #351

Open
Schlaefer opened this issue Jul 29, 2022 · 0 comments · May be fixed by #352
Open

Pages without meta block are rendered empty #351

Schlaefer opened this issue Jul 29, 2022 · 0 comments · May be fixed by #352
Labels

Comments

@Schlaefer
Copy link
Member

A content.md page with

<!--
Title: Welcome
-->

## Welcome

renders fine, while without the meta block

## Welcome

only a blank page is shown. A markdown page should render even without meta block.

Schlaefer added a commit to Schlaefer/Phile that referenced this issue Jul 29, 2022
Schlaefer added a commit to Schlaefer/Phile that referenced this issue Jul 29, 2022
The raw-content has to be split into meta and content.

This was done in two places before (Page and Parser) essentially
duplicating the same functionality. Now this responsibility is delegated to the
Parser, it is the party with the knowledge on how to detect and extract the
meta from the content.

The evaluation of meta and content is still done twice as before, so there's
still room for performance improvement. But at least the implementations are
merged into one code place.
Schlaefer added a commit to Schlaefer/Phile that referenced this issue Jul 29, 2022
The raw-content has to be split into meta and content.

This was done in two places before (Page and Parser) essentially
duplicating the same functionality. Now this responsibility is delegated to the
Parser, it is the party with the knowledge on how to detect and extract the
meta from the content.

The evaluation of meta and content is still done twice as before, so there's
still room for performance improvement. But at least the implementations are
merged into one code place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant