Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using non-TLS-on-connect against TLS-on-connect port should error cleanly, or handle #9

Open
philpennock opened this issue Oct 9, 2023 · 0 comments

Comments

@philpennock
Copy link
Member

At present, using smtpdane -srv submission $DOMAIN without also specifying -tls-on-connect will result in a hang.
(The -submissions shortcut implicitly sets the -tls-on-connect flag.)

We should handle this more gracefully. Hanging forever is not acceptable.

It is acceptable to spot the TLS-on-connect and issue a warning and continue.

It is acceptable to spot the TLS-on-connect and error.

It is acceptable to just have a timeout over the whole handshake and abort when that is exceeded.

At present, we do have the -connect-timeout flag, but that doesn't apply once the connection has been established.

Spotted while investigating #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant