-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alarms do not fire when time is changed #28
Comments
I have the same issue. Alarms are omited if NTPClient updated time. |
I found my problem. Just a short sketch for everybody using a similar code:
Issue arises, due to ntp_time being global. So time is not updated. My current solution:
This is just for information and not related to bug mentioned above. |
A proposal for retriggering as you suggested may be luckyhacky@9b198a9 |
When changing the time in the Time library, TimeAlarms misses alarms.
The expected behavior is:
..in other words, every instance of the time passing through a recurring alarm should result in the alarm firing.
You can demonstrate this bug by
A more practical example of this bug is if the time is set to 7:00PM and you run the clock back to 7:00AM, the alarm will not trigger. This is highly likely to cause alarms (possibly for the whole day) to be missed, and is something a user of an alarm clock might do.
Workaround:
Update the alarm each instance of updating the time:
Where
gTime1
struct holds the hour and minute of the alarm as a global variable.The text was updated successfully, but these errors were encountered: