Retry on error_apple non-terminal error #1148
Open
+73
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kookster
reviewed
Nov 6, 2024
| @@ -19,7 +19,7 @@ class PublishingPipelineState < ApplicationRecord | |||
| scope :latest_failed_pipelines, -> { | |||
| # Grab the latest attempted Publishing Item AND the latest failed Pub Item. | |||
| # If that is a non-null intersection, then we have a current/latest+failed pipeline. | |||
| where(publishing_queue_item_id: PublishingQueueItem.latest_attempted.latest_failed.select(:id)) | |||
| where(publishing_queue_item_id: PublishingQueueItem.latest_attempted.latest_failed.order(id: :asc).select(:id)) | |||
There was a problem hiding this comment.
is that order(:id) appropriate to add to either the latest_attempted or latest_failed scopes?
Also, why :asc? That means the latest will be at the end? Wouldn't the most recently failed make sense as the first?
| def self.retry_failed_pipelines! | ||
| Podcast.where(id: latest_failed_pipelines.select(:podcast_id).distinct).each do |podcast| | ||
| latest_failed_podcasts.each do |podcast| |
There was a problem hiding this comment.
yeah, nicer to have a method for this.
| @@ -1,6 +1,6 @@ | |||
| class PublishingPipelineState < ApplicationRecord | |||
| TERMINAL_STATUSES = [:complete, :error, :expired].freeze | |||
| TERMINAL_FAILURE_STATUSES = [:error, :expired].freeze | |||
| FAILURE_STATUSES = [:error, :expired, :error_apple].freeze | |||
There was a problem hiding this comment.
nice, makes sense to have this grouping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1134
This includes the intermediate
error_applein the list of retryable error states. Prior to this, we had only considered terminal error states. With this PR, we will retry publishing pipelines having intermediateerror_applestates and terminalcomplete(success) states.