Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper change address #22

Open
Duddino opened this issue Mar 17, 2023 · 3 comments
Open

Use proper change address #22

Duddino opened this issue Mar 17, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Duddino
Copy link
Member

Duddino commented Mar 17, 2023

We should use the proper change address instead of using a normal one.
Just change the code to use this function: https://docs.rs/zcash_primitives/latest/zcash_primitives/zip32/sapling/struct.DiversifiableFullViewingKey.html#method.change_address

@Duddino Duddino added bug Something isn't working good first issue Good for newcomers labels Mar 17, 2023
@panleone panleone self-assigned this Mar 18, 2023
@panleone
Copy link
Member

Soo should we close this?

@Duddino
Copy link
Member Author

Duddino commented Mar 27, 2023

I'm gonna take a look at this tomorrow

@Duddino Duddino self-assigned this Mar 27, 2023
@panleone
Copy link
Member

as you want imo it is a useless waste of time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants