Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Box and StructureBox be renamed? #121

Open
SpaceWalkerRS opened this issue Apr 26, 2023 · 0 comments
Open

Should Box and StructureBox be renamed? #121

SpaceWalkerRS opened this issue Apr 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@SpaceWalkerRS
Copy link
Member

C_5577922 and C_7492943, currently named Box and StructureBox respectively, are two classes used to define axis aligned bounding boxes. While Box is used in a variety of contexts like entity and block shapes, collisions, and rendering, StructureBox on the other hand is used exclusively for structure bounding boxes.

For reference, modern mojmaps uses AABB and BoundingBox respectively for these classes.

Should we adopt the mojmaps convention? Stick with our current names? Or do something in between?
@SpaceWalkerRS SpaceWalkerRS added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SpaceWalkerRS