Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a visual style guide for odevs members to follow #22

Open
akozlik opened this issue Feb 6, 2022 · 6 comments
Open

Create a visual style guide for odevs members to follow #22

akozlik opened this issue Feb 6, 2022 · 6 comments
Milestone

Comments

@akozlik
Copy link
Collaborator

akozlik commented Feb 6, 2022

No description provided.

@akozlik akozlik added this to the v1.0 milestone Feb 6, 2022
@jonkurtis
Copy link
Contributor

I think it would be beneficial to use Daisy UI (or something similar) for this instead of writing our own style guide. Daisy UI is a CSS components library plugin for Tailwind CSS that adds themeable components like buttons, cards, etc. We can still use the full power of Tailwind but this will help ensure style consistency and Accessibility with simple class names like btn-primary. I can implement and convert the existing styles over if we are ok with using Daisy.

@akozlik
Copy link
Collaborator Author

akozlik commented Feb 8, 2022

200

@akozlik
Copy link
Collaborator Author

akozlik commented Feb 8, 2022

I only ask that you please document any standards in the README.md so other contributors are aware of the change.

@jonkurtis
Copy link
Contributor

Great, I will set it up and update README.md. Feel free to assign this issue to me if you are able to do that.

@jonkurtis
Copy link
Contributor

Submitted PR for this. I put the style guide docs in README.md for now to make them more likely to be read. We might want to move it to a separate file after we create a contribution guide to keep the README from getting bloated. For now I think it would be best to keep it as visible as possible.

@jonkurtis
Copy link
Contributor

@akozlik can you close this issue if the PR #24 satisfies it?

snohio pushed a commit that referenced this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants