Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Readme] #8

Open
Fabrice-Fabio opened this issue Jul 23, 2023 · 0 comments
Open

[Readme] #8

Fabrice-Fabio opened this issue Jul 23, 2023 · 0 comments

Comments

@Fabrice-Fabio
Copy link
Contributor

Fabrice-Fabio commented Jul 23, 2023 •
edited
Loading

  1. Hello guys, i correct readme cause i've spend 1h before find an error with initialization with the comma which makes error during the initialization.
  2. I've also correct initialization and parsing of "requestParams" during sign and how to get "dataToSign" and "address"
  3. Finally i've add some showDialog() during "eth_sendTransaction" and explain how to send transaction before confirm and cancel transaction.

Feel free to read and update repo with my pull request so it can help community.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fabrice-Fabio