Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] Refactor architecture of OUDS Swift Package product for helpers and view modifiers #144

Open
1 task done
ludovic35 opened this issue Oct 2, 2024 · 1 comment
Labels
🧩 enhancement Related to enhancements or feature requests ⚠️ on hold Not blocked but should not be processed yet 🔍 triage A new issue that needs to be treated

Comments

@ludovic35
Copy link
Member

ludovic35 commented Oct 2, 2024

Prerequisites

As a

user of the library

... I want to

have all view modifiers in same target / Swift package product (like OUDS)

... so that I can

get all helpers in a same place using lower levels products

Motivation and context

Get things cleaner

Proposed Solution

  1. Make some renaming, for example public func typeDisplayLarge(_ theme: OUDSTheme) -> some View should be public func oudsTypographyDisplayLarge(_ theme: OUDSTheme) -> some View

  2. Move modifiers to OUDS Swift package product (are here today in OUDSComponent)

  3. Do the same with shadow helps

  4. View modifiers should be in Modifiers subfolder

  5. A11Y things should be in A11Y subfolder of Modifiers

  6. Typography things should be in Typography subfolder of Modifiers

Other

No response

Contact Details

No response

@ludovic35 ludovic35 added the 🔍 triage A new issue that needs to be treated label Oct 2, 2024
@pylapp pylapp added the 🧩 enhancement Related to enhancements or feature requests label Oct 2, 2024
@pylapp pylapp changed the title [feature]: refacror helpers and viewmodifiers Refactor architecture of OUDS Swift Package product for helpers and view modifiers Oct 2, 2024
@pylapp pylapp changed the title Refactor architecture of OUDS Swift Package product for helpers and view modifiers [Refactoring] Refactor architecture of OUDS Swift Package product for helpers and view modifiers Oct 2, 2024
@pylapp pylapp added the ⚠️ on hold Not blocked but should not be processed yet label Oct 2, 2024
@pylapp
Copy link
Member

pylapp commented Oct 2, 2024

on hold until #137 is merged to prevent conflicts and boring rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 enhancement Related to enhancements or feature requests ⚠️ on hold Not blocked but should not be processed yet 🔍 triage A new issue that needs to be treated
Projects
Status: Triage
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants