Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OdsTextField - Bad content color in dark mode #621

Closed
paulinea opened this issue Sep 5, 2023 · 0 comments · Fixed by #622
Closed

OdsTextField - Bad content color in dark mode #621

paulinea opened this issue Sep 5, 2023 · 0 comments · Fixed by #622
Assignees
@paulinea
Labels
🐞 bug Something isn't working 📗 ods library

Comments

@paulinea
Copy link
Member

paulinea commented Sep 5, 2023 •
edited
Loading

When the component is directly used in the OdsTheme, its content is black in dark mode. It should be white.
@paulinea paulinea added 🐞 bug Something isn't working 📗 ods library labels Sep 5, 2023
@paulinea paulinea self-assigned this Sep 5, 2023
@paulinea paulinea changed the title OdsTextField - When the component is directly used in the OdsTheme, its content is black in dark mode OdsTextField - Bad content color in dark mode Sep 5, 2023
paulinea added a commit that referenced this issue Sep 5, 2023
@paulinea
[#621] Use OdsTheme.colors.onSurface for text field content color
aff4f02
paulinea added a commit that referenced this issue Sep 5, 2023
@paulinea
[#621] Update changelog
ef2115a
@paulinea paulinea linked a pull request Sep 5, 2023 that will close this issue
621 - OdsTextField - Fix content color in dark mode #622
Merged
paulinea added a commit that referenced this issue Sep 5, 2023
@paulinea
[#621] Review: Replace CompositionLocalProvider by a Surface
878d1bb
@florentmaitre florentmaitre mentioned this issue Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulinea paulinea

Labels
🐞 bug Something isn't working 📗 ods library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

621 - OdsTextField - Fix content color in dark mode Orange-OpenSource/ods-android
1 participant
@paulinea