Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numpy 1.24 across all simulators #91

Open
pgleeson opened this issue Jan 24, 2023 · 1 comment
Open

Support numpy 1.24 across all simulators #91

pgleeson opened this issue Jan 24, 2023 · 1 comment

Comments

@pgleeson
Copy link
Member

numpy 1.24 has removed a number of previously deprecated methods/fields (e.g. numpy.int, numpy.float) causing multiple test failures. These changes need to be made in relevant packages (e.g. PyNN) and then this line removed from here:

osb-model-validation/.github/workflows/ci.yml

Line 61 in d40b541

pip install 'numpy<=1.23.0' # temp fix for https://levelup.gitconnected.com/fix-attributeerror-module-numpy-has-no-attribute-float-d7d68c5a4971

pgleeson added a commit to NeuroML/NeuroMLlite that referenced this issue Jan 24, 2023
@pgleeson
Flagging numpy 1.24 issue
0e45630 
OpenSourceBrain/osb-model-validation#91
pgleeson added a commit to NeuroML/NeuroML2 that referenced this issue Jan 26, 2023
@pgleeson
numpy<=1.23.0
a70dec8 
See OpenSourceBrain/osb-model-validation#91
pgleeson added a commit to OpenSourceBrain/NetPyNEShowcase that referenced this issue Jan 26, 2023
@pgleeson
numpy 1.23...
9d0c716 
See OpenSourceBrain/osb-model-validation#91
pgleeson added a commit to OpenSourceBrain/OpenCortex that referenced this issue Jan 26, 2023
@pgleeson
numpy<=1.23.0
57f56d9 
See OpenSourceBrain/osb-model-validation#91
pgleeson added a commit to OpenSourceBrain/Brunel2000 that referenced this issue Jan 27, 2023
@pgleeson
numpy<=1.23.0
27e9715 
See OpenSourceBrain/osb-model-validation#91
pgleeson added a commit to OpenSourceBrain/PotjansDiesmann2014 that referenced this issue Apr 19, 2023
@pgleeson
Use: pip install 'numpy<=1.23.0' # see OpenSourceBrain/osb-model-vali…
25059f5 
…dation#91
@sanjayankur31 sanjayankur31 mentioned this issue Jun 17, 2024
Closed
4 tasks
@sanjayankur31
Copy link
Contributor

Numpy 2.x just got released, so we need to bump up our numpy here to check if it works with new numpy versions. It's affecting other repos and OMV based workflows too, eg:

OpenSourceBrain/SBMLShowcase#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanjayankur31 @pgleeson