Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedestrian Attributes Hip vs. Root #772

Open
ClemensLinnhoff opened this issue Feb 8, 2024 · 4 comments
Open

Pedestrian Attributes Hip vs. Root #772

ClemensLinnhoff opened this issue Feb 8, 2024 · 4 comments

Comments

@ClemensLinnhoff
Copy link
Contributor

Describe the problem

In the definition of the Bones in PedestrianAttributes there is a bone type TYPE_ROOT. Its position relative to the moving object base position, i.e. center of the bounding box, is given by bbcenter_to_root.

However, in the hierarchy image of the bones there is no root bone listed. And in the skeleton image, the root (O_Ref?) is in the same position as the hip.

So what exactly is the difference between root and hip?

This might be related to LudwigFriedmann/OpenMATERIAL#50

@Peintnerer could you maybe shed some light on this?

@Peintnerer
Copy link
Contributor

We defined the "root-bone" as the reference for the entire skeleton model of the pedestrian. So, to know were the reference point of the skeleton is in relation to the bounding box. This additional root point is derived from how rigs are defined in most 3D applications. Usually, the root point coincides with the hip, but not always; Thus we defined it separately.
It's true that it is missing in the hierarchy image, maybe it would make sense to change this for clarity.

@ClemensLinnhoff
Copy link
Contributor Author

But is the root bone an actual bone of the skeleton? Or is it rather a vector from an arbitrary reference point to the hip? I am still not sure I understand the function of this root bone. If it is not a real bone of the skeleton, why not just point from the center of the bounding box to the hip with a bbcenter_to_hip vector?

You say "Usually, the root point coincides with the hip, but not always"
What would be the use-case of not putting the root at the hip?

How does this definition fit to the OpenMATERIAL pedestrian?

@LudwigFriedmann
Copy link

Hi @ClemensLinnhoff, the root bone acts as transform for the skeleton. The bone is 0-dimensional, so it should have length 0.. Nevertheless, it has a special meaning for skeletal animation as a key handling point. Therefore, we introduced the reference coordinate frame (situated in the center of the bounding box) in OpenMATERIAL. As you have correctly recognized, the origin of the reference system and the position of the hip bone do not necessarily coincide.

@LudwigFriedmann
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants