Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electrification beta does not show third rail highlighting #65

Open
JonathanBittner opened this issue Feb 19, 2022 · 3 comments
Open

Electrification beta does not show third rail highlighting #65

JonathanBittner opened this issue Feb 19, 2022 · 3 comments
Labels
bug style:electro electrification style

Comments

@JonathanBittner
Copy link
Contributor

The map legend suggests that lines with third rail electrification should be outlined with gray (#797979) highlighting but this has not been done.

I took a look at this today and have a few ideas, but I think replicating that degree of thickness (50% wider on each side than the actual line) as suggested by the legend would look bad. Also do we want to have third rail highlighting on lines that also have overhead electrification (quite a bit around New York Penn Station and more on the way)? Right now, dual electrification segments are grayed out but that's a different issue.

Thoughts?

@JonathanBittner
Copy link
Contributor Author

I did a quick mock up and test in kosmtik by modifying the electrification.mss file by replicating and modifying the global zoom>=9 casing code. Not sure how we should handle zoom < 9
electrification-diff.txt

@DerDakon
Copy link
Contributor

The legend uses the old MapCSS style, which is independent of the current CartoCSS style and is likely out of sync.

@DerDakon DerDakon added the bug label Feb 19, 2022
@JonathanBittner
Copy link
Contributor Author

Well should I open a bug under OpenRailwayMap/OpenRailwayMap (I think that's where the legend is stored) to update the legend or should I continue working on implementing this? I can make it happen, just have some "artistic" questions.

@DerDakon DerDakon added the style:electro electrification style label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug style:electro electrification style
Projects
None yet
Development

No branches or pull requests

2 participants