Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickSubtitlesConfigMenu screen resize - why? #2357

Open
nautilus7 opened this issue Nov 26, 2019 · 12 comments
Open

QuickSubtitlesConfigMenu screen resize - why? #2357

nautilus7 opened this issue Nov 26, 2019 · 12 comments

Comments

@nautilus7
Copy link
Contributor

Hi, what is the purpose of the screen resize inside the QuickSubtitlesConfigMenu screen? I don't see the reason behind it. Also, if you really want to keep it, it would be better to move it to the default skin and remove it from the python code.

In addition, the resize code is only applied when the "fps" text is not set, why is the case for teletext and dvb subtitles. For pango subtitles (what are these???) the resize is not applied! Why?

@nautilus7
Copy link
Contributor Author

@littlesat @WanWizard any comment about this? Should I remove the resize feature completely?

@WanWizard
Copy link
Member

I'll pass that on, I have no clue about Enigma's internals...

@nautilus7
Copy link
Contributor Author

@littlesat any comment on this? Should I move the resize code to the default skin or even better to remove it completely? Why forcing third party skins to a resized (small) screen?

@WanWizard
Copy link
Member

@littlesat ?

@WanWizard
Copy link
Member

@littlesat ???

@littlesat
Copy link
Member

Sorry for the extreme delay... when the FPS is not there the window can be shortened?

@nautilus7
Copy link
Contributor Author

nautilus7 commented Jan 21, 2020

No problem.

Why forcing all skins to a specific size (height in particular)? Is this the proper way to do it? We could instead add the resize into the default skin, and let third party skins do whatever they like.

@AbuBaniaz
Copy link
Contributor

Are you asking about the small screen after you press red? If so, that screen has to be activated while in full screen mode. This allows user to alter options and see effects in real time.

@nautilus7
Copy link
Contributor Author

nautilus7 commented Jan 28, 2020

I am talking about the QuickSubtitlesConfigMenu. I am sure which is the red button you're talking about, but it doesn't matter.

I understand the necessity of the smaller screen (to be able to see the subs at the same time and check how the settings look like), but the logic is wrong. The resizing shouldn't be forced into the python code. Screen size (with resize or not) should be a choice of each skin.

@littlesat
Copy link
Member

This screen was never intended to make skinnable anyway

@AbuBaniaz
Copy link
Contributor

On a related note, SimonC has added a new feature to VIX.
OpenViX/enigma2#490

@littlesat
Copy link
Member

Can you arrange a Merge request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants