Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add nbest option to top-k / top-p (nucleus sampling) generation #2313

Open
vince62s opened this issue Feb 13, 2023 · 2 comments

Comments

@vince62s
Copy link
Member

This option would enable to re-rank nbest hypotheses generated with nucleus sampling.

@PC91
Copy link
Contributor

PC91 commented Nov 6, 2023

Hello @vince62s,
I would like to know if this feature is already implemented. I am also interested and I could give it a try.
Thank you.

@vince62s
Copy link
Member Author

vince62s commented Nov 6, 2023

It is not implemented yet.
I recently revamped beam_search.py and you can check where we use n_best to make sure we add enough hypotheses. You can easily do the same in greed_search.py it is not difficult, if you have issues let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants