Credis symlinks wrong?

[sreichel]

Preconditions (*)

1. latest 19.4.x (with composer modules added)

Steps to reproduce (*)

1. added this to composer.json

    "magento-deploystrategy": "copy",
    "magento-deploystrategy-dev": "symlink",
    "magento-force": true,

2. run composer install ... symlinks for CM_ are created
3. delete vendor
4. run composer install --no-dev

Expected result (*)

1. symlinks should be replaced by files

Actual result (*)

1. Credis copy fails

[fballiano]

when I do the composer install --no-dev I get:

In Copy.php line 133:
                                                                                                                                                                                                                                                           
  copy(/Users/fab/Projects/openmage/vendor/colinmollenhour/cache-backend-redis/lib/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis/Credis): failed to open stream: Invalid argument   

I think the problem is with the "magento-force" option

[sreichel]

colinmollenhour/Cm_Cache_Backend_Redis#65 is not fixed lib/Credis is empty.

[AGelzer]

Info: magento-composer-installer has problems with change deploy strategy from symlink to copy

See: Pull request #208

[sreichel]

@AGelzer thank you.

@Flyingmana your're maintainer there ... do you have time to review this?

[Flyingmana]

For this I first need to know if the same happens when using modman, as we tried back then to copy the behavior (which included bugs like these if directories were already existing)
Also changing without removing is more or less undefined behaviour.

EDIT:
checked more in detail. The removal of symlinks/files happens only during uninstall of the module, not when vendor is deleted.