Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite generation of _get_item_ #184

Open
jpfeuffer opened this issue Dec 11, 2023 · 0 comments
Open

Rewrite generation of _get_item_ #184

jpfeuffer opened this issue Dec 11, 2023 · 0 comments

Comments

@jpfeuffer
Copy link
Contributor

First of all we should support get_item with e.g. strings for dict like objects.

But, even now for just size types it is not really correct

| cdef long _idx = $call_arg

It should first check for invalid indexes and only then convert to a fitting datatype. Currently we get signedness warnings because it is still a signed long type even after checking positivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant