Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX when there are multiple file readers #932

Closed
TiborGY opened this issue Jun 6, 2022 · 3 comments · Fixed by #1347 or #1348
Closed

Improve UX when there are multiple file readers #932

TiborGY opened this issue Jun 6, 2022 · 3 comments · Fixed by #1347 or #1348
Labels

Comments

@TiborGY
Copy link
Contributor

TiborGY commented Jun 6, 2022

For some file extensions Avogadro currently asks the user which input reader would they like to use. Some of the input readers offered in these situations may not be suitable, and trying to read the file with them will result in an error message and the entire file open process is interrupted.

It would be a better UX to return the user to the format/reader selection dialog if loading the file fails, so the user can quickly choose another input reader, instead of having to browse to the path of the file they were trying to open, all over again.

See discussion at https://discuss.avogadro.cc/t/molpro-import-is-still-regressed-in-avogadro2-1-96-0-compared-to-avogadro1/3855

@ghutchis
Copy link
Member

I think the precedence particularly for "out" or "log" files should be something like:

  • If cclib is installed, try that
  • Otherwise try Open Babel
  • Otherwise try the internal code

@ghutchis ghutchis changed the title Improve UX when the user chooses an incorrect file reader Improve UX when there are multiple file readers Jun 18, 2022
@avo-bot
Copy link

avo-bot commented Apr 6, 2023

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/avogadro-2023-roadmap/4412/1

@ghutchis ghutchis added the bug label May 10, 2023
@ghutchis
Copy link
Member

Okay, this will now be handled by #1347 and #1348 together.

  • One PR ensures that "out" and "log" formats are handled by code which determines the file type, then finds an appropriate reader.
  • One PR auto-selects a format for the user unless shift / control / etc key is held down, in which case the dialog will appear.

I think this should resolve the issue, particularly if cclib is installed (since that has wide utility for Molpro and other compchem programs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants