Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change hash to xxh3, xxhash, aead or murmur etc #2442

Open
kolinfluence opened this issue Mar 3, 2024 · 0 comments
Open

Ability to change hash to xxh3, xxhash, aead or murmur etc #2442

kolinfluence opened this issue Mar 3, 2024 · 0 comments
Assignees
Labels
✏️ Feature New feature or request

Comments

@kolinfluence
Copy link

Which PikiwiDB functionalities are relevant/related to the feature request?

other

Description

currently uses crc32 which is very slow. can do in configuration to switch hash function xxh3 etc.

Proposed solution

i can do this part BUT i need someone to help code the "configuration" parameters into the config file for both codis and pika so i can add xxh3.
i've already done this but hard coded xxh3 by changing internals from crc32.

anyone who can make it a config, pls do in .conf file

hash =  "crc32" // <-- this and i will add 1. fnv1a & 2. xxh3 function and features into both pika and codis. 

so basically means need someone to help make it parameterized will do. thx

Alternatives considered

i've hardcoded xxh3 into both pika and codis and saw a 22% increase in speed improvement.
e.g. 80000 req/s to 100000 req/s

@kolinfluence kolinfluence added the ✏️ Feature New feature or request label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant