Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form embed not working #201

Open
peterkwells opened this issue May 13, 2015 · 8 comments
Open

Form embed not working #201

peterkwells opened this issue May 13, 2015 · 8 comments

Comments

@peterkwells
Copy link

@pezholio @Floppy can someone help?

As part of loading up the Error Creative stuff via this PR: #199

I inserted the demo form (via instructions at http://embed.openaddressesuk.org/) in a couple of places, namely:

https://github.com/OpenAddressesUK/theodolite/blob/master/app/views/static/services/free-format-address-input.md
https://github.com/OpenAddressesUK/theodolite/blob/master/app/views/static/blog/_posts/2015-05-13-free-format-user-research.md

To support the form I put the embed code in:

https://github.com/OpenAddressesUK/theodolite/blob/master/app/views/shared/_head.html.erb

This worked fine locally but fails in live. I can't see any differences. Can one of you take a look?

@pezholio
Copy link
Member

Ah, it's because https://alpha.openaddressesuk.org/services/free-format-address-input is loaded over https and the browser is blocking it because it's being loaded from an insecure site. I'll look into it

@pezholio
Copy link
Member

Yeah, I think this is because we're hosting the the embed code on Github pages. I thought we could have a custom domain with https, but apparently not 😞

There's two options here:

Whaddya reckon?

@peterkwells
Copy link
Author

if it gives the same functionality/experience to the end-user then .io

Let's not add more costs right now...

@pezholio
Copy link
Member

Yeah, that was my instinct too. I'll get on it.

@peterkwells
Copy link
Author

👍

@pezholio
Copy link
Member

Got a PR here #202

@peterkwells
Copy link
Author

sorted

@peterkwells
Copy link
Author

@pezholio looks like we still have something lingering on this

  1. See: https://twitter.com/OHCamshaft/status/598539396128833537
  2. I tested and works fine from Mac on Safari and Chrome, but fails (404) on iOs/Safari. Haven't checked other combos.

@peterkwells peterkwells reopened this May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants