Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spreadsheet converts to empty list of networks #95

Open
Bjwebb opened this issue May 18, 2023 · 6 comments
Open

Spreadsheet converts to empty list of networks #95

Bjwebb opened this issue May 18, 2023 · 6 comments

Comments

@Bjwebb
Copy link
Collaborator

Bjwebb commented May 18, 2023

data.xlsx

http://openfibrecove-build-lxml.dokkudev3.ods.mobi/data/929ae69a-1b97-4730-8e1b-b63b9de684ee

@duncandewhurst
Copy link
Contributor

Hmm, the issue occurs on the live version, too: https://ofds.cove.opendataservices.coop/data/99c71809-d53e-4416-9342-3da36f9e1456

@odscjames please could you investigate? If possible, we should implement tests to catch this type of issue.

@odscjames
Copy link
Collaborator

Also noting the UI claims the original data is a CSV file and not the Excel file

@duncandewhurst
Copy link
Contributor

This was definitely working in the past because I was using CoVE to convert the spreadsheets that I created using https://github.com/Open-Telecoms-Data/ofds_qgis_template into JSON files.

@odscjames
Copy link
Collaborator

It's not the latest security changes Ben did tho - tested locally and commit c807233 still broken

@odscjames
Copy link
Collaborator

Fix now live! Leaving open so can look at test comment.

@duncandewhurst
Copy link
Contributor

Confirming that this is working on live. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants