Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CSV upload interface #15

Open
duncandewhurst opened this issue Oct 25, 2022 · 5 comments
Open

Improve the CSV upload interface #15

duncandewhurst opened this issue Oct 25, 2022 · 5 comments
Assignees

Comments

@duncandewhurst
Copy link
Contributor

CSV is the tabular publication format for OFDS data (rather than Excel) so we need to support validating multiple CSV files.

The following Flatten Tool command generates the desired JSON file when run against the example CSV files:

flatten-tool unflatten examples/csv -s schema/network-schema.json -m networks -f csv -o test.json
@odscjames odscjames self-assigned this Oct 26, 2022
@odscjames odscjames transferred this issue from Open-Telecoms-Data/lib-cove-ofds Nov 2, 2022
@odscjames odscjames mentioned this issue Nov 2, 2022
odscjames added a commit that referenced this issue Nov 7, 2022
#15

Also change to using settings from Django settings,
which allows possibility that COVE app can override settings in
libcoveweb
@duncandewhurst
Copy link
Contributor Author

I've done some testing with the CSV files in the examples/csv directory of the standard repository (results). Generally, looks good, but a few things to update:

  • The CSV upload interface is awkward. It involves a lot of clicking to upload multiple CSV files and there aren't enough boxes to upload all the CSV files in the examples/csv directory of the standard repository. Can we have a single 'Browse' button that opens a dialog in which the user can select multiple files? If not, can we have a single browse button that the user can click as many times as they want to add multiple files?

Image

  • There are many validation errors. It looks like the conversion from CSV to JSON is not schema-aware. When I submit the test.json file generated by the Flatten Tool command in the issue description I get only one error (results).

  • In both the upload interface and the results interface, replace 'CSVs' with 'CSV'.

  • Add a URL option to the upload interface. It can either be one text box that accepts a single URL with a button that the user can click multiple times to add multiple URLs (preferred option), or it can be a single text box that accepts a comma-separated list of URLs.

@odscjames
Copy link
Collaborator

The CSV upload interface is awkward.

Was a first pass - it would also be really neat to have one of those "drag and drop" things too.

It looks like the conversion from CSV to JSON is not schema-aware.

Was waiting for schema ref 404 to be fixed - on 2022-11-08 now

In both the upload interface and the results interface, replace 'CSVs' with 'CSV'.

on 2022-11-08 now

@duncandewhurst
Copy link
Contributor Author

duncandewhurst commented Nov 8, 2022

The changes on 2022-11-08 look good.

The priority outstanding action for this issue is updating the upload interface with one of the options suggested in my previous comment.

@odscjames
Copy link
Collaborator

"The priority outstanding action for this issue" means "The CSV upload interface is awkward"?

@duncandewhurst
Copy link
Contributor Author

Yes - the two options suggested to fix it in that bullet point.

@duncandewhurst duncandewhurst changed the title Add support for uploading multiple CSV files to CoVE Improve the CSV upload interface Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants