Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align point handling in load_collection/spatial_extent and filter_spatial #502

Open
soxofaan opened this issue Apr 30, 2024 · 3 comments
Open

Comments

@soxofaan
Copy link
Member

soxofaan commented Apr 30, 2024

filter_spatial explicitly mentions support for points and lines (alongside polygons) in the provided geometry.

While spatial_extent in load_collection is most commonly used with a bounding box, it also can be GeoJSON/Vectorcube, and it looks the intention is to have equivalence between (pseudocode):
load_collection(spatial_extent=geoms) and load_collection().filter_spatial(geoms).

However only Polygons are allowed in load_collection/spatial_extent (in single, multi-, feature or feature collection variants). Points nor Lines are explicitly mentioned and seem to be forbidden, which is a bit of alignment problem between load_collection and filter_spatial.

@soxofaan
Copy link
Member Author

cc @VictorVerhaert @VincentVerelst

@m-mohr
Copy link
Member

m-mohr commented May 16, 2024

Why is it a problem? In principle we could allow all spatial types in load_collection, but as load_collection is already pretty complex, the intention was to keep things simpler for a process that everyone needs to implement.

@soxofaan
Copy link
Member Author

It's just to make things more consistent and intuitive, for example to ensure full equivalence between load_collection(spatial_extent) and load_collection().filter_spatial(spatial_extent).
If a backend supports points in the latter construct, I'd hope it's trivial to do that in the former too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants