Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify no-data value / null / NaN / character encoding for most processes #480 #490

Open
wants to merge 3 commits into
base: draft
Choose a base branch
from
Open

Clarify no-data value / null / NaN / character encoding for most processes #480 #490

wants to merge 3 commits into from

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Jan 3, 2024 •
edited
Loading

Fixes #480 and related issues:

  • No-data values vs. null
  • NaN
  • Character encoding for strings

Guide for no-data values and character encoding have been added to https://github.com/Open-EO/openeo-processes/blob/nodata/meta/implementation.md

@m-mohr m-mohr added this to the 2.0.0 milestone Jan 3, 2024
@m-mohr m-mohr mentioned this pull request Jan 3, 2024
Closed
@m-mohr m-mohr changed the title Clarify no-data value / null / NaN for most processes #480 Clarify no-data value / null / NaN / character encoding for most processes #480 Jan 3, 2024
@m-mohr m-mohr marked this pull request as ready for review January 3, 2024 14:02
This was referenced Jan 3, 2024
Open
Open
@m-mohr m-mohr linked an issue Jan 3, 2024 that may be closed by this pull request
null vs NaN #480
Open
soxofaan
soxofaan reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got through this giant PR yet, but here are some comments already.

Also note that some comments probably apply to multiple other places, I didn't cover yet

all.json Outdated Show resolved Hide resolved
any.json Outdated Show resolved Hide resolved
arccos.json Outdated Show resolved Hide resolved
absolute.json Outdated Show resolved Hide resolved
between.json Show resolved Hide resolved
array_interpolate_linear.json Show resolved Hide resolved
array_find.json Show resolved Hide resolved
array_find.json Outdated Show resolved Hide resolved
arctan2.json Show resolved Hide resolved
@m-mohr m-mohr requested a review from soxofaan August 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeraldIr GeraldIr Awaiting requested review from GeraldIr

@clausmichele clausmichele Awaiting requested review from clausmichele

@soxofaan soxofaan Awaiting requested review from soxofaan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

null vs NaN
2 participants
@m-mohr @soxofaan