Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding imaginary unit #459

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Adding imaginary unit #459

merged 1 commit into from
Sep 14, 2023

Conversation

clausmichele
Copy link
Member

This should be the good one @m-mohr. Sorry for the chaos with the previous PRs, I did a mess.

@m-mohr m-mohr requested a review from aljacob August 23, 2023 10:04
@m-mohr m-mohr changed the title Adding imaginary unit - 3 Adding imaginary unit Aug 23, 2023
@soxofaan
Copy link
Member

soxofaan commented Aug 24, 2023

just curious: what is this for, and how are complex numbers expected to be handled in data cubes? E.g. do you get a data cube with some band-like dimension, having a real and imaginary bands?

edit: never mind, I found

@m-mohr m-mohr linked an issue Aug 24, 2023 that may be closed by this pull request
@PondiB PondiB merged commit ff802c0 into Open-EO:draft Sep 14, 2023
1 check passed
@soxofaan
Copy link
Member

soxofaan commented Sep 14, 2023

hmm I wonder if this should have been merged, @PondiB

I don't think we were already sure that adding the imaginary unit was a good first step for #455

@PondiB
Copy link
Member

PondiB commented Sep 14, 2023

@soxofaan, Well noted, my bad. It's reverted on #464 . Could you approve the revert?

@m-mohr m-mohr mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex numbers in openEO
4 participants