Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do the overall change and check on MVBS_ds #98

Open
ldr426 opened this issue Jun 15, 2023 · 0 comments
Open

Do the overall change and check on MVBS_ds #98

ldr426 opened this issue Jun 15, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@ldr426
Copy link
Collaborator

ldr426 commented Jun 15, 2023

We can do the overall change from MVBS_ds to just ds.

To ensure people put in the right type of dataset, we should add a input checking method that is called in Echogram.__init__ to check for the following:

  • existence of the Sv data variable
  • Sv data variable should have dimensions ("channel", "ping_time", "echo_range")

We should also allow depth in the last dimension, but we can do that later -- I'll create an issue so that we do not forget.

Originally posted by @leewujung in #93 (comment)

@ldr426 ldr426 added the bug Something isn't working label Jun 15, 2023
@ldr426 ldr426 added feature request New feature or request and removed bug Something isn't working labels Jun 15, 2023
@leewujung leewujung added this to the Refactoring echoshader milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants