You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We can do the overall change from MVBS_ds to just ds.
To ensure people put in the right type of dataset, we should add a input checking method that is called in Echogram.__init__ to check for the following:
existence of the Sv data variable
Sv data variable should have dimensions ("channel", "ping_time", "echo_range")
We should also allow depth in the last dimension, but we can do that later -- I'll create an issue so that we do not forget.
We can do the overall change from
MVBS_ds
to justds
.To ensure people put in the right type of dataset, we should add a input checking method that is called in
Echogram.__init__
to check for the following:Sv
data variableSv
data variable should have dimensions ("channel", "ping_time", "echo_range")We should also allow
depth
in the last dimension, but we can do that later -- I'll create an issue so that we do not forget.Originally posted by @leewujung in #93 (comment)
The text was updated successfully, but these errors were encountered: