Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the dots no longer works #25

Open
ehultee opened this issue Sep 13, 2023 · 5 comments
Open

Clicking the dots no longer works #25

ehultee opened this issue Sep 13, 2023 · 5 comments

Comments

@ehultee
Copy link
Member

ehultee commented Sep 13, 2023

Last I checked (June 2022, when we drafted the OGGM-Edu Lab 1), students could click the dots in the map view and information about the correct glacier type would appear at the side. Now, all the types still appear at the side as tabs but the clicking functionality does not do anything.

In case this is browser/OS dependent: I am using Google Chrome 116.0.5845.187 on Mac OSX Big Sur 11.3.1. I tried on Safari and found the same problem. But my internet connection is also bad.

Suggested fix:
(1) Find and correct a bug that broke the clicking function or
(2) Remove the instructions at the top and on the webpage that prompt users to click.

@fmaussion
Copy link
Member

Correct - @pat-schmitt is on parental leave at the moment but I think the easiest would be to fix the instructions.

@pat-schmitt
Copy link
Member

I just updated the HTML files by running the notebook again and it is now working again for me. Maybe you also can check the new files I attached here.

html_files.zip

I don't know why it was not working, but probably I forgot to update the HTML files the last time I was working on the app...

@pat-schmitt
Copy link
Member

If they are working, we need to update them also on the oggm-edu website https://github.com/OGGM/oggm-edu

@fmaussion
Copy link
Member

Yes this is working for me now with your version

@pat-schmitt
Copy link
Member

The app is now working again on the website. Thanks @ehultee for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants