Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NZSL - 31. JavaScript Unit Testing #382

Open
louise-r-blue opened this issue Oct 2, 2018 · 3 comments
Open

NZSL - 31. JavaScript Unit Testing #382

louise-r-blue opened this issue Oct 2, 2018 · 3 comments
Labels
help wanted Needs discussion question to do

Comments

@louise-r-blue
Copy link
Contributor

Which frontend testing framework - Jest?
@louise-r-blue louise-r-blue changed the title JavaScript Unit Testing NZSL - 31. JavaScript Unit Testing Oct 2, 2018
@eoinkelly
Copy link
Contributor

I think unit testing the existing JS would pretty much require a re-write of it. I think we should focus testing efforts on end-to-end testing (Capybara wrapping Selenium) and not worry about unit testing the JS for the forseeable future.

@eoinkelly
Copy link
Contributor

@Br3nda What's your take on this? I think we can probably close it but happy to go along with your call.

@Br3nda
Copy link
Member

Br3nda commented Feb 19, 2019

I think we should rewrite the jquery. I'm not sure if we go with pulling in reactjs, or if we only really need the js that comes with bootstrap/foundation/whatever. It feels like we only do tiny display tweaks, and that vocab card functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Needs discussion question to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Br3nda @eoinkelly @louise-r-blue