New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the way we call indexes in PyCall #21

Open

JordiBolibar opened this issue Jul 10, 2023 · 0 comments

Labels

Member

JordiBolibar commented Jul 10, 2023

PyCall now gives the following warning:

┌ Warning: `getindex(o::PyObject, i::Integer)` is deprecated, use `get(o, i - 1)` instead.
│   caller = trim_period(period::StepRange{Dates.Date, Dates.Day}, climate::PyCall.PyObject) at climate_utils.jl:179
└ @ Sleipnir ~/.julia/packages/Sleipnir/ym2eO/src/glaciers/climate_utils.jl:179

We should update this to avoid having breaking changes in the future.

JordiBolibar added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment