-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parameters local #36
Comments
Partially fixed by #37. Check if more stuff can be moved to the local scope. |
This has been improved in #39. @facusapienza21 to check if more parameters needs to be moved to the local scope for the tests. |
I am not sure if this problems is related to this issue, but I would like to understand why
I am not sure where this variable is originally being created, since it seems the value specified in
This makes all the plots to be saved with |
Yes, I'm aware of this. Some changes might have slipped to the main branch unwillingly. I'll try to fix this asap, but for now, basically you just have to make const current_epoch = Ref{Int}(1) And then just update current epoch wherever you want in the code by doing: global current_epoch[] += 1 The codebase is in a very fragile and experimental situation right now. As soon as we settle things up a little bit, we need to fix the tests and have them running again. |
This is mainly tracked now in #82, which is solved with the new |
Right now we still have some parameters as
const
global variables. This is OK for simplicity's sake for now, but it is annoying when re-running code, as the variables cannot be redefined.This is also problematic for testing, since we want to make sure that we control the local environment of the simulation.
For all these reasons, we need to pass explicitly all the necessary variables (e.g.
B
orH₀
) incontext
, in order to avoid having them asconst
.The text was updated successfully, but these errors were encountered: