Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when running pde_solver_test() with all glaciers #23

Open
facusapienza21 opened this issue Aug 5, 2023 · 0 comments
Open

Error when running pde_solver_test() with all glaciers #23

facusapienza21 opened this issue Aug 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@facusapienza21
Copy link
Member

The test pde_solve_test,

@testset "PDE solving integration tests" pde_solve_test(; rtol=0.01, atol=0.01, save_refs=false, MB=false, fast=true)

fails when fast=false. This just runs the test with a larger list of glaciers, but there is some of them with missing data that make the test fail.

    if fast
        rgi_ids = ["RGI60-11.03638", "RGI60-11.01450", "RGI60-08.00213", "RGI60-04.04351", "RGI60-01.02170"]
    else
        rgi_ids = ["RGI60-11.03638", "RGI60-11.01450", "RGI60-08.00213", "RGI60-04.04351", "RGI60-01.02170",
        "RGI60-02.05098", "RGI60-01.01104", "RGI60-01.09162", "RGI60-01.00570", "RGI60-04.07051",                	
        "RGI60-07.00274", "RGI60-07.01323",  "RGI60-01.17316"]
    end

It will be good idea to omit those or fix the problem in some other way.

@facusapienza21 facusapienza21 added the bug Something isn't working label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants