-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cooperator: Confirmation e-mail is sent too soon #76
Comments
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
PR/Issue without recent activity, it'll be soon closed automatically.
label
Dec 10, 2023
bump |
huguesdk
added
no stale
Use this label to prevent the automated stale action from closing this PR/Issue.
and removed
stale
PR/Issue without recent activity, it'll be soon closed automatically.
labels
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Module
cooperator
Describe the bug
In the
create()
method ofsubscription.request
, there is this line:I have two objections to this:
The reason, I believe, that this line exists, is for people who submit their subscription request online. The flow is this:
To Reproduce
Affected versions: All, I think. 14.0 at least.
Steps to reproduce the behavior:
Expected behavior
I see two obvious solutions:
draft
. When switching to this state, send the e-mail. The name of this state could beconfirmed
,processing
,sen[d|t]
, or some such. This implies a change in workflow for people working with this module. There is a reverted commit in [14.0] cooperator: Multi-company e-mail templates #73 that does this.cooperator_website
code, add a line to send the e-mail after the request is created. This implies a change (reduction) in functionality: confirmation e-mails are no longer sent when requests are manually created in the back-end.Additional context
Add any other context about the problem here. (e.g. OS, Python version, ...)
The text was updated successfully, but these errors were encountered: