-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubecolor: 0.0.21 -> 0.0.25, switch back to upstream, cleanup maintai… #238942
Conversation
@SuperSandro2000: a few things. Would be cool if you could respond :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, except for the homepage and changelog update.
I sometimes remove not so active looking maintainers to so that a package does not look more active maintained then it really is. In the end I'd rather have one active maintainer on a package instead of 3 inactive.
If you take a close look at the diff, then you see that kubecolor/kubecolor has not any significant changes, they mostly changed the import path and also the readme, ci and one code change. Compared to the original which had some more major changes. |
8421a5b
to
0000007
Compare
I feel like there is a chance you might have confused kubecolor/kubecolor with hidetatz/kubecolor. I would argue, kubecolor/kubecolor has more "significant" changes.
applies to hidetatz/kubecolor 👀 |
I compared them again and the only relevant change is kubecolor/kubecolor@f5983ea#diff-58f406e38e3da16176434f1366d55aeeb357db33dec0d28a6e96714d80c50e77 and kubecolor/kubecolor@f5983ea#diff-6fda8dfbacb16a290308a43224a4965a24238e2a09a7048b24b1d15a37c02d87 . Everything else is not really relevant to the nixpkgs packaging. |
…ners
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)