-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove --hpack
support
#628
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I agree with the comments on #3751 – cabal2nix shouldn’t keep growing as new ways to produce a Cabal file appear. It makes sense that the Cabal file is central, and some tools can produce Cabal files while others consume them. So I’m proposing the opposite.
There are two paths here, I think:
hpack - | cabal2nix
(orhpack && cabal2nix
) is sufficient for “hpack support”; orcabal2nix --pre hpack
orcabal2nix --pre dhall-hpack-cabal
.While the first option is ultimately simpler, I think it involves larger changes in downstream projects, so the second option seems much more practical.
Footnotes
https://github.com/NixOS/cabal2nix/pull/375#pullrequestreview-153642460 and https://github.com/NixOS/cabal2nix/pull/375#issuecomment-431089214 ↩
The text was updated successfully, but these errors were encountered: