Remove Either struct #129
Merged
Remove Either struct #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please clarify, what is the reason of removing |
Zerg1996
force-pushed
the
6-consistency-applications-remove-either-struct
branch
from
c2f2143
to
c28c408
Compare
This tl-b struct hard to migrate to ssz and merkle patricia trie. In case where everything cell - it's easy to run over graph of cells, but when every our struct unique - we need to understand what we have X or ^X in our data. Also now we want to make everything struct flat (without reference to our cells) in first point (it's easier to create merkle patricia trie), thats why we don't need such struct at all. |
Zerg1996
force-pushed
the
6-consistency-applications-remove-either-struct
branch
from
ff9341e
to
656e42b
Compare
Zerg1996
force-pushed
the
6-consistency-applications-remove-either-struct
branch
from
534078f
to
521b93b
Compare
…ions-remove-either-struct
shermike
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR removed all part where body or init can be CellSlice, now it's always ref.