Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime error is raised when iterating tree in Python3.7 #11

Open
EdwardWooCN opened this issue Dec 3, 2021 · 3 comments
Open

Runtime error is raised when iterating tree in Python3.7 #11

EdwardWooCN opened this issue Dec 3, 2021 · 3 comments

Comments

@EdwardWooCN
Copy link

This error occurs in function iter_slice(self, slice: slice) -> Iterator[Record].
Since python 3.5, when StopIteration is raised inside a generator, it is replaced with RuntimeError. The alternative is return. (See in https://www.python.org/dev/peps/pep-0479/)
I have verified this change.

@NicolasLM
Copy link
Owner

Hi, makes sense. Would you mind sending a PR?

@EdwardWooCN
Copy link
Author

I have just checked the code in github, it is already fixed 3 years ago by you. But it is not fixed in the pip package(version 0.0.3).

@NicolasLM
Copy link
Owner

Right, I should make a release to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants