From 26769c4270748a7f46157ff0b12429aa89e4b137 Mon Sep 17 00:00:00 2001 From: emost22 Date: Wed, 28 Jun 2023 16:04:50 +0900 Subject: [PATCH 1/2] fix(about, project, recruitment, footer, contact): fix link to open on a new page --- components/about/review/card.vue | 2 +- components/footer.vue | 4 ++-- components/project/project/card.vue | 4 ++-- components/project/project/detail.vue | 1 + components/recruitment/banner.vue | 1 + components/recruitment/linkButton.vue | 10 +++++++++- pages/contact.vue | 4 ++-- pages/recruitment.vue | 1 + 8 files changed, 19 insertions(+), 8 deletions(-) diff --git a/components/about/review/card.vue b/components/about/review/card.vue index 48fee73..c2cc456 100644 --- a/components/about/review/card.vue +++ b/components/about/review/card.vue @@ -19,7 +19,7 @@ const ReviewCard = defineComponent({ }, methods: { onClick: function () { - window.location.href = this.href; + window.open(this.href); }, }, }); diff --git a/components/footer.vue b/components/footer.vue index 80f4973..35dab37 100644 --- a/components/footer.vue +++ b/components/footer.vue @@ -16,7 +16,7 @@ :key="sponsor.idx" class="sponsorItem" > - + {{ sponsor.name }} @@ -26,7 +26,7 @@
diff --git a/components/project/project/card.vue b/components/project/project/card.vue index fc07461..a2c9a53 100644 --- a/components/project/project/card.vue +++ b/components/project/project/card.vue @@ -20,7 +20,7 @@ @click="onClickLink(link)" @click.stop="" > - + {{ platform }}
@@ -59,7 +59,7 @@ const ProjectCard = defineComponent({ methods: { ...mapActions({ showDetail: "project/showDetail" }), onClickLink(href) { - window.location.href = href; + window.open(href); }, scrollToId(id) { document.getElementById(id).scrollIntoView(); diff --git a/components/project/project/detail.vue b/components/project/project/detail.vue index 9efb469..6706845 100644 --- a/components/project/project/detail.vue +++ b/components/project/project/detail.vue @@ -37,6 +37,7 @@ :key="platform" class="link-item" :href="link" + target="_blank" > {{ platform }} diff --git a/components/recruitment/banner.vue b/components/recruitment/banner.vue index 47f5de8..cef3dde 100644 --- a/components/recruitment/banner.vue +++ b/components/recruitment/banner.vue @@ -19,6 +19,7 @@ class="box" :button-name="box.name" :href="`${box.link}`" + :is-new-page=true /> diff --git a/components/recruitment/linkButton.vue b/components/recruitment/linkButton.vue index 98ba150..995a6f8 100644 --- a/components/recruitment/linkButton.vue +++ b/components/recruitment/linkButton.vue @@ -26,10 +26,18 @@ export default defineComponent({ type: String, require: false, }, + isNewPage: { + type: Boolean, + require: false, + } }, methods: { onClick: function () { - location.href = this.href; + if (this.isNewPage) { + window.open(this.href); + } else { + location.href = this.href; + } }, }, }); diff --git a/pages/contact.vue b/pages/contact.vue index 9d236cd..36017a4 100644 --- a/pages/contact.vue +++ b/pages/contact.vue @@ -72,11 +72,11 @@ export default defineComponent({ handleClick: (action) => () => { switch (action) { case "kakao": { - window.location.href = "https://pf.kakao.com/_xdxmnnj"; + window.open("https://pf.kakao.com/_xdxmnnj"); break; } case "facebook": { - window.location.href = "https://www.facebook.com/Nexterspage"; + window.open("https://www.facebook.com/Nexterspage"); break; } case "gmail": { diff --git a/pages/recruitment.vue b/pages/recruitment.vue index 9201e54..2ac6b94 100644 --- a/pages/recruitment.vue +++ b/pages/recruitment.vue @@ -37,6 +37,7 @@ class="faqBox" :button-name="`FAQ 바로가기`" :href="`/contact#faq`" + :is-new-page=false /> From 50f6de890671c35ef08560058b16974bc66dde67 Mon Sep 17 00:00:00 2001 From: emost22 Date: Thu, 13 Jul 2023 14:25:04 +0900 Subject: [PATCH 2/2] fix(recruitment): fix to isNewPage require is true --- components/recruitment/linkButton.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/recruitment/linkButton.vue b/components/recruitment/linkButton.vue index 995a6f8..9504a93 100644 --- a/components/recruitment/linkButton.vue +++ b/components/recruitment/linkButton.vue @@ -28,7 +28,7 @@ export default defineComponent({ }, isNewPage: { type: Boolean, - require: false, + require: true, } }, methods: {