Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank/empty params #1

Open
leemeichin opened this issue Jan 10, 2014 · 1 comment
Open

Blank/empty params #1

leemeichin opened this issue Jan 10, 2014 · 1 comment

Comments

@leemeichin
Copy link
Contributor

Should the gem ignore empty params when no default is supplied? We're doing this manually in Amnesty atm because the assumed default creates a malformed query (passing an empty string to an integer field).

@iainbeeston
Copy link

I think so, yes.

I think it should be possible to specify that a param is required (or not). Then if a required param is not set then no results should be returned for the query (regardless of the other parameters). If a parameter is not required (ie. the default) then if that param is not set then it should not be included in the query at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants