Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test easyh5 on older releases of MATLAB and improve for compatibility #8

Closed
fangq opened this issue May 4, 2020 · 2 comments
Closed

Test easyh5 on older releases of MATLAB and improve for compatibility #8

fangq opened this issue May 4, 2020 · 2 comments
Assignees
@fangq
Labels
bug Something isn't working

Comments

@fangq
Copy link
Member

fangq commented May 4, 2020

@ftadel reported various errors and warnings when running easyh5 on older versions of MATLAB (older than R2016 on which it was developed).

brainstorm-tools/brainstorm3#283 (comment)
@fangq fangq self-assigned this May 4, 2020
@fangq fangq added the bug Something isn't working label May 4, 2020
@fangq fangq closed this as completed in 600c2d1 May 5, 2020
fangq added a commit that referenced this issue May 5, 2020
@fangq
add parentheses for test condition, #8
2951909
@fangq
Copy link
Member Author

fangq commented May 15, 2020 •
edited
Loading

more compatibility focused fixes to run easyh5 on matlab 2014 or earlier

fangq@ef1ccdc

basically, matlab 2014b and earlier uses hdf5 1.8.6 (H5.get_libversion()), and this version of hdf5 can not save empty datasets, according to

h5py/h5py#559
keras-team/keras#3208

@ftadel
Copy link

ftadel commented May 15, 2020

Thanks.
Reported here: brainstorm-tools/brainstorm3@9a9da7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fangq fangq

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fangq @ftadel