Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce structs corresponding 1-1 to FLINT structs, use them inside our wrappers like e.g. FpFieldElem or fqPolyRepFieldElem #1875

Open
fingolfin opened this issue Sep 30, 2024 · 1 comment

Comments

@fingolfin
Copy link
Member

          (...) We could (... add ...) a separate struct `fq_nmod_t` (and `fmpz_t` etc. etc.) which faithfully replicate the FLINT structs, nothing more and nothing less. Then e.g. `fqPolyRepFieldElem` could start with a member `x:: fq_nmod_t`. 

That way, we could resolve all the lies in the code everywhere. But that would be a major piece of work for relatively limited gain (if I were to start Nemo today, that's more or less what I'd do anyway, but as it is now...).

Originally posted by @fingolfin in #1871 (comment)

@thofma
Copy link
Member

thofma commented Sep 30, 2024

For some types there are already _struct versions, e.g. qqbar_struct.

Claus and I discussed at various points rewriting the wrapper code, also to deal with some of the current shortcomings. Just saying this so so that we don't duplicate efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants