Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Workflow should not request outputs, especially timestep, by default #5188

Open
shorowit opened this issue May 8, 2024 · 2 comments
Open

Comments

@shorowit
Copy link
Contributor

shorowit commented May 8, 2024

Enhancement Request

By default, an OpenStudio workflow will request a variety of monthly and, worse, timestep/daily outputs. For users that care about runtime speed or file size, this is problematic. Why does OpenStudio assume everyone wants these outputs? If certain reports or workflows or applications need these outputs, they can easily request them.

(Technically these can be skipped by using the skip_energyplus_preprocess option, but that's not easy to know and many end users may not have access to this option with how they are running simulations. And this option might do more than just skip these outputs, I'm not sure.)

Issue originally raised on Unmet Hours.

@shorowit shorowit added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 8, 2024
@jmarrec
Copy link
Collaborator

jmarrec commented Oct 30, 2024

I don't really know, this was already in workflow-gem, I just ported it.

My money is on the fact that this was added for the openstudio_results measure (and maybe the Output:Table:Monthly so that the E+ html output is more useful too).

@DavidGoldwasser could we ensure these are ported to the openstudio_results measure instead of always added by the Workflow?

@jmarrec jmarrec added component - Workflow and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Oct 30, 2024
@DavidGoldwasser
Copy link
Collaborator

That makes sense. I think when that code was added pre-dated reporting measures and it was more hard coded in OS App. We should be able to add what we want to the EnergyPlus output request section of OpenStudio results measure. Will have to check if updates also needed for calibration measures and measures in URBANopt.

@DavidGoldwasser DavidGoldwasser added this to the OpenStudio SDK 3.10.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants