From da7d25f23fb2a616cc15e7ee7452c84aa17b7f25 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=9CRobHanna-NOAA=E2=80=9D?=
<“Robert.Hanna@NOAA.gov”>
Date: Thu, 17 Oct 2024 23:46:29 +0000
Subject: [PATCH 1/3] fix error bug
---
fim_post_processing.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fim_post_processing.sh b/fim_post_processing.sh
index e866f3c9..676b5a7c 100755
--- a/fim_post_processing.sh
+++ b/fim_post_processing.sh
@@ -275,11 +275,11 @@ l_echo $startDiv"Scanning logs for errors and warnings. This can take quite a fe
echo "Results will be saved in root not inside the log folder."
Tstart
# grep -H -r -i -n "error" $outputDestDir/logs/ > $outputDestDir/all_errors_from_logs.log
- find $outputDestDir -type f | grep -H -r -i -n "error" $outputDestDir/logs/ > \
+ find $outputDestDir -type f | grep -H -R -i -n ".*error.*" $outputDestDir/logs/ > \
$outputDestDir/all_errors_from_logs.log &
l_echo "error scan done, now on to warnings scan"
- find $outputDestDir -type f | grep -H -r -i -n "warning" $outputDestDir/logs/ > \
+ find $outputDestDir -type f | grep -H -R -i -n ".*warning.*" $outputDestDir/logs/ > \
$outputDestDir/all_warnings_from_logs.log &
l_echo "warning scan done"
Tcount
From 4bd578968e9fa62ddef89cb5bbe8d2b9e13f369b Mon Sep 17 00:00:00 2001
From: Rob Hanna - NOAA <90854818+RobHanna-NOAA@users.noreply.github.com>
Date: Thu, 17 Oct 2024 17:57:16 -0600
Subject: [PATCH 2/3] Update CHANGELOG.md
---
docs/CHANGELOG.md | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index 64f33c96..1ace5d98 100755
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -1,6 +1,21 @@
All notable changes to this project will be documented in this file.
We follow the [Semantic Versioning 2.0.0](http://semver.org/) format.
+
+## v4.5.x.x - 2024-10-17 - [PR#1320](https://github.com/NOAA-OWP/inundation-mapping/pull/1320)
+
+The fix: During the post processing scan for the word "error" or "warning", it was only finding records which had either of those two words as stand alone words and not part of bigger phrases. ie); "error" was found, but not "fielderror". Added wildcards and it is now fixed.
+
+Note: it is finding a good handful more errors and warnings that were being missed in earlier code versions.
+
+### Changes
+`fim_post_processing.sh`: fix as described.
+
+
+
+
+
+
## v4.5.11.0 - 2024-10-11 - [PR#1298](https://github.com/NOAA-OWP/inundation-mapping/pull/1298)
This PR addresses four issues regarding OSM bridges. It dissolves touching bridge lines so each bridge has a single linestring. It also removes abandoned bridge from the dataset and it adds bridge type field to bridge centroids. As part of this PR, `max_hand_ft` and `max_discharge_cfs` columns are added to `osm_bridge_centroids.gkpg`.
From 3b9fb732be4d26e22e9179ef2f861c571f7e4142 Mon Sep 17 00:00:00 2001
From: RobHanna-NOAA
Date: Fri, 25 Oct 2024 19:06:41 +0000
Subject: [PATCH 3/3] update changelog
---
docs/CHANGELOG.md | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
index e2d03545..f818d53d 100755
--- a/docs/CHANGELOG.md
+++ b/docs/CHANGELOG.md
@@ -2,7 +2,7 @@ All notable changes to this project will be documented in this file.
We follow the [Semantic Versioning 2.0.0](http://semver.org/) format.
-## v4.5.x.x - 2024-10-17 - [PR#1320](https://github.com/NOAA-OWP/inundation-mapping/pull/1320)
+## v4.5.11.3 - 2024-10-25 - [PR#1320](https://github.com/NOAA-OWP/inundation-mapping/pull/1320)
The fix: During the post processing scan for the word "error" or "warning", it was only finding records which had either of those two words as stand alone words and not part of bigger phrases. ie); "error" was found, but not "fielderror". Added wildcards and it is now fixed.
@@ -11,6 +11,9 @@ Note: it is finding a good handful more errors and warnings that were being miss
### Changes
`fim_post_processing.sh`: fix as described.
+
+
+
## v4.5.11.2 - 2024-10-25 - [PR#1322](https://github.com/NOAA-OWP/inundation-mapping/pull/1322)
For security reasons, we needed to create a docker image that does not use the root user in anyway. The new `Dockerfile.prod` file is to be used when we want to use a non-root user. The original `Dockerfile` has been renamed to `Dockerfile.dev` and will continue to use it's root users which has no problems with interacting with external mounts.
@@ -35,7 +38,6 @@ In the Dockerfile.prod, you can not do installs or update using either pipenv or
-
## v4.5.11.1 - 2024-10-16 - [PR#1318](https://github.com/NOAA-OWP/inundation-mapping/pull/1318)
Bug fixes to address issues during `fim_pipeline.sh`.